[BUG] ShipStationIP Basic Authentication

[SmolSoftBoi]

Type of Connector

Independent Publisher Connector

Name of Connector

ShipStationIP

Describe the bug

The API definition has basic authentication, but this is not asked for?

Is this a security bug?

No, this is not a security bug

What is the severity of this bug?

Severity 1 - Connector is broken or there's a very serious issue

To Reproduce

Add a connection, no basic authentication is asked for.

Expected behavior

Basic authentication should be asked for.

Environment summary

Install Method: Power Automate

Additional context

…

[natalie-pienkowska]

Thank you @SmolSoftBoi for submitting this issue! @Amjed-Ayoub will take a look at this issue with his team and then get back to you with an update.

[Amjed-Ayoub]

Hi @SmolSoftBoi, Thank you so much for reaching out. Please allow me some time to work with our engineers on this. Please expect to hear back from me soon. Thank you so much again for your patience and understanding.

[v-EgorKozhadei]

Hi @SmolSoftBoi,

Thank you for submitting an issue!

I was able to reproduce the bug. I analyzed connector files and found a few things.

For creating a connection with Basic Authentication we need a username and a password. In the apiProperties file the connectionParameters property is not defined, that's why it's not asking for authentication. Also I haven't found the security property in apiDefinition.swagger.json file. It's necessary to define the connectionParameters property in apiProperties.json and securityDefinitions and security properties in apiDefinition.swagger.json.

I can provide an example from one of the existing IP connectors called UdemyIP. Please take a look at securityDefinitions and security properties from apiDefinition.swagger.json file and at connectionParameters property from apiPropertiesjson file.

Could you please raise a quick PR with a fix in the open-source repository?

Let us know if you have any questions or need help!

[SmolSoftBoi]

Fixed in #1813

[v-EgorKozhadei]

Hello @SmolSoftBoi,

Closing the issue because it was fixed in the PR mentioned above.

Please let us know by reopening the issue if there are any problems.