OpticSim.jl icon indicating copy to clipboard operation
OpticSim.jl copied to clipboard
verified publisher icon microsoft

Emitters.Spectrum.Measured docs/examples/tests

Open alfredclwong opened this issue 4 years ago • 1 comments

Measured{T} could do with some examples and completed docs. I'm also not sure about re-using T as a variable name in L85.

https://github.com/microsoft/OpticSim.jl/blob/c2e31018eb5fd369ce426ce906628484bb676d4d/src/Optical/Emitters/Spectrum.jl#L83-L97

alfredclwong avatar Apr 30 '21 12:04 alfredclwong

the redefinition of T on L85 is redundant but shouldn't affect correctness. Should be deleted. I'll ask Joel to measure a light spectrum for us that we can use as an example.

BrianGun avatar Apr 30 '21 18:04 BrianGun