microsoft
Add several syntactical, functional and logic improvements (#11)
You will see that the pipeline fails at the "Run unit tests" step and here is why.
We discovered that on ubuntu-latest (Ubuntu 20.04), one of the tests from the Microsoft.OpenApi.Tests project fails. The test is called Microsoft.OpenApi.Tests.OpenApiWorkspaceTests.OpenApiWorkspacesShouldNormalizeDocumentLocations.
The same test completes successful on Windows 10 and windows-latest (Windows Server 2019).
Now to make it even more interesting, in the previous iteration of the pipeline you can see in the logs that the test fails, but for some odd reason, there is no exit code and therefor the pipeline doesn't fail.
In the one this PR is for, the same test again fails BUT now the pipeline also fails as it should.
In case this fail is a false positive, we've tested the pipeline on windows-latest and everything runs smoothly, since the test in question does not fail, so we can switch the runner of the CI job from ubuntu-latest to windows-latest.
Other than that, check out in a bit the comments on each change for info on the optimizations.
Resolves #594
Also, I forgot to mention that based on this PRs resolution, we will optimize the CodeQL pipeline as well.
@baywet it is an incredible coincidence, but today we discovered that the action for creating release in this pipeline is unmaintained and is quite unstable, so we decided to replace it with a short script utilizing GitHub CLI.
I was just about to commit the change and it will show in this PR, so it would be more convenient for merging.