MixedRealityToolkit-Unity icon indicating copy to clipboard operation
MixedRealityToolkit-Unity copied to clipboard

Fixed GetAsync method in Rest class

Open Proton-V opened this issue 3 years ago • 2 comments

Changes

  • Fixes: #10766

Overview

Fixed problem with using request in Rest.cs class

Fixes

  • ProcessRequestAsync method in Rest.cs

Proton-V avatar Jul 28 '22 04:07 Proton-V

@keveleigh Hello. I see this warning from azure. I think you can approve these changes and pipeline will accept branch?

Proton-V avatar Jul 29 '22 01:07 Proton-V

@keveleigh Hello. I see this warning from azure. I think you can approve these changes and pipeline will accept branch?

I'll pull this down and test it out today! Thanks!

keveleigh avatar Jul 29 '22 17:07 keveleigh

@keveleigh updates on this?

Zee2 avatar Aug 23 '22 02:08 Zee2

Thanks for this fix! Worked great for me locally. I pushed one slight change to BytesToString, as I was hitting a null ref in cases where the connection wasn't successful. This change allowed subsequent errors to surface for debugging purposes.

keveleigh avatar Oct 04 '22 22:10 keveleigh