MixedReality-GraphicsTools-Unity icon indicating copy to clipboard operation
MixedReality-GraphicsTools-Unity copied to clipboard

Error in Acrylic Render Pass

Open mgrubert-ml opened this issue 2 years ago • 5 comments

Describe the bug

Error due to AcrylicBlur shader in Unity 2023.1.x : Library\PackageCache\com.microsoft.mrtk.graphicstools.unity@cd59e032bb2e\Runtime\Experimental\Acrylic\Scripts\AcrylicBlurRenderPass.cs(189,13): error CS0619: 'ScriptableRenderPass.ConfigureTarget(RenderTargetIdentifier)' is obsolete: 'Use RTHandle for colorAttachment'

To reproduce

Create URP project in Unity 2023.1.14f1, then used MRTK tool to import Graphicstools and try to open project.

Your setup (please complete the following information)

  • Unity Version 2023.1.14f1
  • 0.5 and 0.61

Target platform (please complete the following information)

  • Standalone PC
  • Android

mgrubert-ml avatar Oct 28 '23 01:10 mgrubert-ml

Thanks @mgrubert-ml - we will take a look at this. We don't yet support Unity 2023. But will eventually and address this.

Cameron-Micka avatar Oct 30 '23 19:10 Cameron-Micka

@Cameron-Micka The Readme.MD says "The Graphics Tools package requires Unity 2021.3 and above." Might be helpful to put an upper bound there as well (Unity 2021.3 thru Unity 2022.x)

mgrubert-ml avatar Nov 08 '23 20:11 mgrubert-ml

Great idea @mgrubert-ml!

Cameron-Micka avatar Nov 09 '23 19:11 Cameron-Micka

I was able to update it to the new API by following this guide: rendertargethandle-is-obsolete-deprecated-in-favor-of-rthandle

Torgo13 avatar Nov 20 '23 14:11 Torgo13

That's a wonderful resource, thanks @Torgo13. If you are able to make a PR with your changes, I would be happy to review it as well. 😊

Cameron-Micka avatar Nov 27 '23 18:11 Cameron-Micka

Hey @mgrubert-ml, this should be fixed now with v0.7.0 and above.

Cameron-Micka avatar May 07 '24 21:05 Cameron-Micka