LMOps icon indicating copy to clipboard operation
LMOps copied to clipboard

Bug in Logit Processor?

Open SaeedNajafi opened this issue 1 year ago • 1 comments

Don't you have a bug in the logit processor? It seems you don't even use the processed scores in the wrapper.

https://github.com/microsoft/LMOps/blob/96e7d9d086cba6cd878c98ac810902eae1323d8b/minillm/transformers/src/transformers/generation/utils.py#L2942

SaeedNajafi avatar Sep 30 '24 14:09 SaeedNajafi

Thanks for pointing it out! We have fixed this issue in this commit.

t1101675 avatar Sep 30 '24 15:09 t1101675