FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Remove webpack from build:compile scripts for propertyDDS packages

Open ChumpChief opened this issue 3 years ago • 3 comments

Partial fix for #8455 (does not resolve the sporadic pack failure). On my slow dev box this reduces npm run ci:build time by ~13%.

The examples require property-inspector-table to be packed before they'll run, I think because they use it from a .js file (?) but didn't look too far. A little inconvenient, but not too bad -- I think the efficiency gain is worth it. Webpack-fluid-loader has a similar issue that I didn't tackle in this PR.

Also resolve build warning for missing rimraf dependency.

ChumpChief avatar Mar 24 '22 18:03 ChumpChief

fyi @evaliyev @karlbom @nedalhy @ruiterr

anthony-murphy avatar Mar 24 '22 18:03 anthony-murphy

Looks like it's saving ~40s (~14%) on npm run ci:build in the PR validation pipeline as well.

ChumpChief avatar Mar 24 '22 18:03 ChumpChief

I believe the most recent build errors are due to a reliance on webpack being part of the build process for the property-inspector-table package. I'm pausing this PR to investigate that a bit further (will likely make a PR to normalize the build/config of the package to align it better with the rest of the repo) and then will come back to this.

ChumpChief avatar Mar 25 '22 19:03 ChumpChief

Incremental build seems to handle these correctly now so I'm less concerned about this. Would still likely be a nice improvement but I don't think I'll pick this back up.

ChumpChief avatar Oct 10 '22 16:10 ChumpChief