FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Include service URL and request method in r11s request errors

Open kian-thompson opened this issue 1 year ago • 1 comments

Troubleshooting live-site issues and customer reported issues will become easier. Ex: If Container creation failures have service URL and response code, it'll be easier to identify point of failure and come-up with a fix to mitigate/fix the incident.

This gives AFR a good idea about the APIs which are failing, which cluster it was going to, and which cluster group it was going to. It helps AFR correlate the errors on the server better.

Examples

Here are some examples of request calls. Only the bolded parts can be logged, and the first line of each entry below is just the type of request being made (no need to log it):

CreateDocument (or CreateContainer) POST https://us.fluidrelay.azure.com/documents/someId

Connect
GET https://alfred.southcentralus-1.fluidrelay.azure.com/socket.io/?documentId=someId&tenantId=someId&EIO=4&transport=websocket

GetDelta
GET https://alfred.southcentralus-1.fluidrelay.azure.com/deltas/someId/someId?from=0&to=2001

GetSummary
GET https://historian.southcentralus-1.fluidrelay.azure.com/repos/someId/git/summaries/latest?token=someToken&disableCache=true

PostSummary
POST https://historian.southcentralus-1.fluidrelay.azure.com/repos/someId/git/summaries?token=someToken

FindSessionFirst Request POST https://alfred.southcentralus-1.fluidrelay.azure.com/documents/someId/session/someId

Fixes AB#18452

kian-thompson avatar Oct 18 '24 23:10 kian-thompson

@fluid-example/bundle-size-tests: +910 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 462.72 KB 462.76 KB +35 Bytes
azureClient.js 560.3 KB 560.94 KB +649 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 261.67 KB 261.68 KB +14 Bytes
fluidFramework.js 405.97 KB 405.98 KB +14 Bytes
loader.js 134.16 KB 134.18 KB +14 Bytes
map.js 42.46 KB 42.46 KB +7 Bytes
matrix.js 148.29 KB 148.29 KB +7 Bytes
odspClient.js 526.83 KB 526.88 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 164.48 KB 164.49 KB +7 Bytes
sharedTree.js 396.43 KB 396.43 KB +7 Bytes
Total Size 3.32 MB 3.32 MB +910 Bytes

Baseline commit: 199b9d051239d8dba8215153e565c2cadbc1ecef

Generated by :no_entry_sign: dangerJS against 3e422df3f3fec4309871a3d52ce5f4a28b5c756f

msfluid-bot avatar Oct 19 '24 00:10 msfluid-bot

I assume the response status code and method are already being logged, correct ?

arikt-ms avatar Oct 21 '24 21:10 arikt-ms