Remove deprecated inbound and outbound queues on IDeltaManager
Description
Task Link: 7202
1.) Remove deprecated inbound and outbound queues on IDeltaManager. 2.) Move them to IDeltaManagerInternal so that internal Fluid layers can still use it but not the apps.
⯅ @fluid-example/bundle-size-tests: +890 Bytes
| Metric Name | Baseline Size | Compare Size | Size Diff |
|---|---|---|---|
| aqueduct.js | 463.61 KB | 463.77 KB | ⯅ +171 Bytes |
| azureClient.js | 562.45 KB | 562.71 KB | ⯅ +276 Bytes |
| connectionState.js | 724 Bytes | 724 Bytes | ■ No change |
| containerRuntime.js | 261.86 KB | 262 KB | ⯅ +150 Bytes |
| fluidFramework.js | 424.82 KB | 424.84 KB | ⯅ +14 Bytes |
| loader.js | 134.17 KB | 134.19 KB | ⯅ +19 Bytes |
| map.js | 42.71 KB | 42.71 KB | ⯅ +7 Bytes |
| matrix.js | 148.32 KB | 148.33 KB | ⯅ +7 Bytes |
| odspClient.js | 528.29 KB | 528.48 KB | ⯅ +190 Bytes |
| odspDriver.js | 97.84 KB | 97.86 KB | ⯅ +21 Bytes |
| odspPrefetchSnapshot.js | 42.81 KB | 42.83 KB | ⯅ +14 Bytes |
| sharedString.js | 164.17 KB | 164.17 KB | ⯅ +7 Bytes |
| sharedTree.js | 415.28 KB | 415.29 KB | ⯅ +7 Bytes |
| Total Size | 3.36 MB | 3.36 MB | ⯅ +890 Bytes |
Baseline commit: 8d470085fb41a84212a993a1ebbbf903fd4f16b6
Generated by :no_entry_sign: dangerJS against 6710b814e7112e8977119a7de940c9c06eacb706
Didn't go through the whole thing, just a couple of comments below, and a general comment that I thought we were still holding off on any breaking changes (including to
@alpha/@legacyAPIs).
Yeah, I am not going to merge it until it is allowed to make breaking changes, but want to get review/approval so that I can just merge when it is allowed and to know if it is ok to make this change.
@jason-ha and @Josmithr Please take a look at this PR when you get time. Thanks.
Two new notes:
- We just had another break change break Loop. I would recommend running (rerunning) the Loop integration tests as due diligence.
- Please add a change set. Tyler just added a "Legacy API Changes" section so the changeset can target that. (Set
"section"tolegacy)
Integration pipeline with Loop succeeded for the breaking change: https://dev.azure.com/office/OC/_build/results?buildId=32410848&view=results
🔗 Found some broken links! 💔
Run a link check locally to find them. See https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.
linkcheck output
> [email protected] ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full
1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"
> [email protected] ci:start
> http-server ./public --port 1313 --silent
> [email protected] linkcheck:full
> npm run linkcheck:fast -- --external
> [email protected] linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external
Crawling...
http://localhost:1313/docs/start/tree-start/
- (3430:89) 'here' => https://github.com/microsoft/FluidFramework/blob/main/packages/dds/tree/docs/main/merge-semantics.md (HTTP 404)
Stats:
443676 links
3413 destination URLs
2 URLs ignored
0 warnings
1 errors
ELIFECYCLE Command failed with exit code 1.
Will make the change in another PR. Auto merge was on, so it got merged.