FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Replace summaryOnDemand by summarizeNow

Open pragya91 opened this issue 1 year ago • 2 comments

Followup from PR: https://github.com/microsoft/FluidFramework/pull/22173 Replaced summarizeOnDemand() with summarizeNow() so that the loadContainer utility can be provided with the summaryVersion. This ensures that the container refers to the latest snapshot and not some stale one.

pragya91 avatar Aug 09 '24 22:08 pragya91

⚠️ No Changeset found

Latest commit: d28b2d98ca50fbf4ca928f998a656fa1916ee379

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 09 '24 22:08 changeset-bot[bot]

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 457.44 KB 457.47 KB +35 Bytes
azureClient.js 554.61 KB 554.66 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 258.11 KB 258.12 KB +14 Bytes
fluidFramework.js 406.79 KB 406.81 KB +14 Bytes
loader.js 134.1 KB 134.11 KB +14 Bytes
map.js 42.13 KB 42.14 KB +7 Bytes
matrix.js 146.42 KB 146.42 KB +7 Bytes
odspClient.js 522.76 KB 522.8 KB +49 Bytes
odspDriver.js 97.55 KB 97.57 KB +21 Bytes
odspPrefetchSnapshot.js 42.61 KB 42.62 KB +14 Bytes
sharedString.js 163.14 KB 163.15 KB +7 Bytes
sharedTree.js 397.31 KB 397.31 KB +7 Bytes
Total Size 3.3 MB 3.3 MB +245 Bytes

Baseline commit: 7a9c3c052fde2b1b88d8123613988b0b7f461385

Generated by :no_entry_sign: dangerJS against d28b2d98ca50fbf4ca928f998a656fa1916ee379

msfluid-bot avatar Aug 09 '24 23:08 msfluid-bot