FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

feat(devtools): Add accessibilty test coverage for Devtools

Open WayneFerrao opened this issue 1 year ago • 2 comments

AB#8206

Description

This PR adds accessibility test coverage for Fluid Dev Tools to the following components:

  • Menu
  • AudienceStateTable
  • AudienceHistoryTable
  • OpLatencyView

WayneFerrao avatar Jun 28 '24 20:06 WayneFerrao

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 454.67 KB 454.7 KB +35 Bytes
azureClient.js 552.27 KB 552.31 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 255.97 KB 255.99 KB +14 Bytes
fluidFramework.js 385.11 KB 385.13 KB +14 Bytes
loader.js 134.01 KB 134.03 KB +14 Bytes
map.js 42.17 KB 42.17 KB +7 Bytes
matrix.js 145.44 KB 145.45 KB +7 Bytes
odspClient.js 520.06 KB 520.11 KB +49 Bytes
odspDriver.js 96.94 KB 96.96 KB +21 Bytes
odspPrefetchSnapshot.js 42.23 KB 42.24 KB +14 Bytes
sharedString.js 162.52 KB 162.53 KB +7 Bytes
sharedTree.js 375.58 KB 375.58 KB +7 Bytes
Total Size 3.24 MB 3.24 MB +245 Bytes

Baseline commit: 775079fd2f0e2ad4d987b14443cc5ce4691a2ab4

Generated by :no_entry_sign: dangerJS against 5035034ba4a67774067db857345c2aa50cd74d1a

msfluid-bot avatar Jun 28 '24 20:06 msfluid-bot

Left one nit comment, but everything LGTM.

Are we planning to have a follow-up work on testing ContainerSummaryView? I think it will be really nice if we can test how sub-components (e.g.,ContainerDataView, AudienceStateTable & AudienceHistoryTable) work with ContainerSummaryView.

Screenshot 2024-06-28 at 17 14 47

For example, once the container is closed. The user should have focus on Client ID of AudienceHistoryTable after User ID of ContainerSummaryView.

jikim-msft avatar Jun 29 '24 00:06 jikim-msft

@jikim-msft @alexvy86 Yes, there is a task tracking the remaining components that need coverage and I updated it to include ContainerSummaryView

WayneFerrao avatar Jul 01 '24 17:07 WayneFerrao