FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Retry count sample

Open pragya91 opened this issue 1 year ago • 1 comments

This PR helps add retryCount to the service calls made by the driver. This would enable services (specifically FRS) to track scope of degradation of their services by using this parameter.

Note: This code has not been tested yet. Inviting an early feedback from the devs on the feasibility or concerns about this implementation.

pragya91 avatar Jun 21 '24 16:06 pragya91

Overall, I like this direction as the logic is quite localized for what it is worth.

jatgarg avatar Jun 21 '24 17:06 jatgarg

@fluid-example/bundle-size-tests: +487 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 456.49 KB 456.53 KB +35 Bytes
azureClient.js 554.23 KB 554.51 KB +291 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 257.7 KB 257.72 KB +14 Bytes
fluidFramework.js 391.41 KB 391.43 KB +14 Bytes
loader.js 134.1 KB 134.11 KB +14 Bytes
map.js 42.17 KB 42.17 KB +7 Bytes
matrix.js 145.43 KB 145.44 KB +7 Bytes
odspClient.js 522.23 KB 522.28 KB +49 Bytes
odspDriver.js 97.17 KB 97.19 KB +21 Bytes
odspPrefetchSnapshot.js 42.27 KB 42.29 KB +14 Bytes
sharedString.js 162.51 KB 162.52 KB +7 Bytes
sharedTree.js 381.87 KB 381.88 KB +7 Bytes
Total Size 3.26 MB 3.26 MB +487 Bytes

Baseline commit: 2cb1e358aa231429b72c7fb3fce95e4b6e66c8a9

Generated by :no_entry_sign: dangerJS against e7402e6cb25b5f6840027dd5ec57b68bc068fb6f

msfluid-bot avatar Jul 10 '24 19:07 msfluid-bot