FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Use dynamic import for attributor in runtime instead of mixin

Open jatgarg opened this issue 1 year ago • 3 comments

Description

Shift package from @fluid-experimental/attributor to @fluidframework/attributor inside runtime packages and then use dynamic import for attributor in runtime instead of Mixin so as to not increase bundle size by default in case someone is not using fluid attributor. Only 3KB size is increased for container runtime.

jatgarg avatar Jun 11 '24 19:06 jatgarg

diff here probably looks a lot better if you remove the old attributor package at the same time (files should largely be moves)

Abe27342 avatar Jun 19 '24 17:06 Abe27342

diff here probably looks a lot better if you remove the old attributor package at the same time (files should largely be moves)

But @fluid-experimental should not be getting counted in size here. The size diff is actually 3Kb and not 18KB because same container runtime is getting calculated in other modules like azure client, odsp client etc. @Abe27342

Got it. It is for the diff and not the size

jatgarg avatar Jun 19 '24 17:06 jatgarg

Baseline CI build failed, cannot generate bundle analysis at this time


Baseline commit: 8c246f943b1e7e154b9ccde65984186c4073330c

Generated by :no_entry_sign: dangerJS against daf7125fe3f3b073c9d7bb1641015a97629dbfe5

msfluid-bot avatar Jun 19 '24 18:06 msfluid-bot

Closing this PR for now based on the comment in the ADO task in the description.

jatgarg avatar Jul 08 '24 22:07 jatgarg