FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

[Summarization] Added type for the error thrown during summarization

Open agarwal-navin opened this issue 1 year ago • 1 comments

The error thrown during summarization go through multiple layers - container runtime -> summary generator -> running summarizer. Currently, the error type is Error and it gets lost while is moves through these layers.

This change fixes this by improving the types of the summarizer errors through these layers. It does the following:

  • Uses IRetriableFailureResult consistently as the error type throughtout all these layers.
  • In SummaryGenerator / RunningSummarizer, ensures that all failures have an error associated with them.
  • Removes the error from the failure results which was a duplicate of the error in the base result.

agarwal-navin avatar May 15 '24 00:05 agarwal-navin

@fluid-example/bundle-size-tests: +281 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 453.91 KB 453.98 KB +74 Bytes
azureClient.js 551.15 KB 551.22 KB +77 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 257.75 KB 257.82 KB +74 Bytes
fluidFramework.js 359.58 KB 359.58 KB No change
loader.js 132.91 KB 132.91 KB No change
map.js 41.45 KB 41.45 KB No change
matrix.js 143.67 KB 143.67 KB No change
odspClient.js 519.69 KB 519.75 KB +56 Bytes
odspDriver.js 97.29 KB 97.29 KB No change
odspPrefetchSnapshot.js 42.15 KB 42.15 KB No change
sharedString.js 160.19 KB 160.19 KB No change
sharedTree.js 359.58 KB 359.58 KB No change
Total Size 3.2 MB 3.2 MB +281 Bytes

Baseline commit: ed6d28fea2af1ac9358fad58136825d0ff9dfbf0

Generated by :no_entry_sign: dangerJS against 40a28f2f2e60607a24cab88c609147887501ecdd

msfluid-bot avatar May 15 '24 01:05 msfluid-bot