FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Make the new summary retry logic the default and remove old logic

Open agarwal-navin opened this issue 2 years ago • 1 comments

https://github.com/microsoft/FluidFramework/pull/16885 added a new retry mechanism in case of summarization failures. This was rolled out with A/B testing and the experiment was successful. This PR makes the new retry mechanism default and removes the old one.

Notes

  • Added retry for these two additional scenarios - When a summary op or summary ack is not received within the timeout, retry. This is because these failures are mostly transient and a retry may fix them.
  • Removed refreshLatestAck summary option because its not used anymore. A lot of the code changes are because of this.

AB#7605

agarwal-navin avatar Apr 25 '24 19:04 agarwal-navin

@fluid-example/bundle-size-tests: -7.47 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 454.95 KB 453.08 KB -1.87 KB
azureClient.js 552.06 KB 550.19 KB -1.87 KB
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 258.8 KB 256.93 KB -1.87 KB
fluidFramework.js 357.54 KB 357.54 KB No change
loader.js 132.78 KB 132.78 KB No change
map.js 41.45 KB 41.45 KB No change
matrix.js 143.67 KB 143.67 KB No change
odspClient.js 520.6 KB 518.74 KB -1.86 KB
odspDriver.js 97.29 KB 97.29 KB No change
odspPrefetchSnapshot.js 42.15 KB 42.15 KB No change
sharedString.js 160.19 KB 160.19 KB No change
sharedTree.js 357.53 KB 357.53 KB No change
Total Size 3.2 MB 3.19 MB -7.47 KB

Baseline commit: 89bdf9c21643d16373012b3fe48a6b5af83a72e1

Generated by :no_entry_sign: dangerJS against 5e58ef00589197094d16ca6cadda8075bf6b4225

msfluid-bot avatar Apr 25 '24 19:04 msfluid-bot