microsoft
[RC1] GC: Port recent telemetry changes
Port the following commits to RC1 branch:
- f2b744a7f92e52fe40ec2e66bcb824bd3ac14cd9
- 059fc1896bbb11419e62e1351c50a2c23f1d3d1c
- 059fc1896bbb11419e62e1351c50a2c23f1d3d1c
- 68e6f921898cfa5b8210eb72304cdc89259c44de (partial)
Our GC early adopters are seeing a handful (less than 10) docs that are somehow trying to load deleted objects. The changes being ported here will aid in that analysis, helping to confirm or refute some assumptions we're having to make based on the current data.
The risk of these changes is low - it's scoped to GC plus some heavily-tested ContainerRuntime codepaths, and is mostly logging changes or light refactoring.
@markfields, can you please add some description on why you are porting those, what is the risk, what happens if we forgo poring.
⯅ @fluid-example/bundle-size-tests: +2.73 KB
| Metric Name | Baseline Size | Compare Size | Size Diff |
|---|---|---|---|
| aqueduct.js | 472.29 KB | 473.61 KB | ⯅ +1.33 KB |
| connectionState.js | 680 Bytes | 680 Bytes | ■ No change |
| containerRuntime.js | 275.18 KB | 276.49 KB | ⯅ +1.31 KB |
| loader.js | 169.26 KB | 169.29 KB | ⯅ +22 Bytes |
| map.js | 77.15 KB | 77.16 KB | ⯅ +11 Bytes |
| matrix.js | 175.83 KB | 175.84 KB | ⯅ +11 Bytes |
| odspDriver.js | 90.71 KB | 90.73 KB | ⯅ +22 Bytes |
| odspPrefetchSnapshot.js | 42.32 KB | 42.33 KB | ⯅ +11 Bytes |
| sharedString.js | 194.76 KB | 194.77 KB | ⯅ +11 Bytes |
| sharedTree.js | 306.87 KB | 306.87 KB | ■ No change |
| Total Size | 1.88 MB | 1.88 MB | ⯅ +2.73 KB |
Baseline commit: 9417d80515ce2937be3270251b4f8bb313da010d
Generated by :no_entry_sign: dangerJS against c29ae4dc8932a185f30d1cb6149392d1883d2793
Not planning to merge this for now, to avoid introducing any risk to RC1. Partner team waiting for this is close to bumping to RC2 and it'll be in the next patch release there.