FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Move sequence and merge-tree to new applyStashedOps model, and add fuzz

Open anthony-murphy opened this issue 1 year ago • 1 comments

Background

This change is related to https://github.com/microsoft/FluidFramework/pull/19518. That change introduced a new and simpler mechanism for applying stash ops. Specifically, it allows dds to reuse their existing flows for creating local changes, rather than needing custom flows to apply the change and get the local op metadata. This reduces complexity, bundle size, and bug potential by having fewer code paths to do the same thing; apply changes locally.

Overview

This change moves merge-tree, sequence, and interval collections to the new applyStashedOps model. Beyond that i've done some clean up in the interval collection code to clean up a few things which made making the change easier:

  • removed redundant constants for reservedIntervalIdKey
  • collapsed messageHandlers to the single existing messageHandler
  • improved type handling with the use of type guard.
  • deleted a bunch of applyStashedOps code that is no longer necessary

AB#7145

anthony-murphy avatar Feb 17 '24 00:02 anthony-murphy

Baseline CI build failed, cannot generate bundle analysis at this time


Baseline commit: 2fee891cd3d82a5390fe6baa50f0701879b03731

Generated by :no_entry_sign: dangerJS against 410f97c44fcd7a3f31fbba29bbfb15fdc7d610bc

msfluid-bot avatar Feb 17 '24 00:02 msfluid-bot