FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Experiments with uncoupling `Container` and `Loader` (FHL)

Open alexvy86 opened this issue 3 years ago • 2 comments

Description

FHL experiments around uncoupling the Container from the Loader. First objective is to make Container instantiatable without a Loader, and as a realistic test, have AzureClient do it that way.

Reviewer Guidance

Does this introduce a breaking change?

Any relevant logs or outputs

Other information or known dependencies

alexvy86 avatar Sep 19 '22 22:09 alexvy86

@fluid-example/bundle-size-tests: +125 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 397.35 KB 397.35 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 196.29 KB 196.29 KB No change
loader.js 153.48 KB 153.6 KB +125 Bytes
map.js 42.89 KB 42.89 KB No change
matrix.js 131.83 KB 131.83 KB No change
odspDriver.js 151.8 KB 151.8 KB No change
odspPrefetchSnapshot.js 39.88 KB 39.88 KB No change
sharedString.js 153.04 KB 153.04 KB No change
Total Size 1.27 MB 1.27 MB +125 Bytes

Baseline commit: 8425983d3423a28662e27f2c4415c5d13db52bd0

Generated by :no_entry_sign: dangerJS against 9b441c412876ec4704b778002cf37bd593464fa8

msfluid-bot avatar Sep 20 '22 18:09 msfluid-bot

I'm not a fan of the approach on this commit, with a static Container.loader, just putting it out there as a possible approach as part of the experiments. Want to see if something breaks in the tests.

alexvy86 avatar Sep 20 '22 22:09 alexvy86