FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Fix lockfiles for historian

Open alexvy86 opened this issue 3 years ago • 0 comments

Description

Something seems to have gone wrong with these two recent changes to the lockfiles for historian, which I believe resulted in what we see right now in our pre-production deployment of R11s, where the historian container is in a crash-loop-backoff saying it cannot find module url-parse when executing amqplib/lib/connect.js (query in Azure Monitor)

In the first change, amqplib was updated, but a section for its dependency url-parse disappeared from lerna-package-lock.json (even though the dependency was still declared under amqplib).

image

Maybe related to the fact that the amqplib dependency itself disappeared from under @fluidframework/server-services.

image

In the second one, the dependencies for amqplib disappeared completely from under it:

image

In this PR I just removed lerna-package-lock.json from server/historian and ran npm i again to regenerate it. Running the install without removing the file was not fixing the issues.

Relevant extracts from this change:

amqplib dependency restored under @fluidframework/server-services:

image

amqplib dependencies show up under it again:

image

url-parse has its own section:

image

FYI @robertobe-ms not exactly a rollback, just trying to fix the issues.

alexvy86 avatar Sep 14 '22 21:09 alexvy86