FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Simplify state machine of pending summary state after summary is submitted

Open NicholasCouri opened this issue 3 years ago • 1 comments

The initial goal for this task was to simplify the state machine of the pending summary state after a summary is submitted.

In order to better understand how often the scenario happens, we are simply adding a telemetry event that will be logged whenever the proposal handle is not on the pendingsummaries list.

Addressing part of #AB444

Note: this will also help understand a problem on FRS in which the pendingsummaries list never seems to have the proposal handle.

NicholasCouri avatar Aug 10 '22 21:08 NicholasCouri

@fluid-example/bundle-size-tests: +930 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 388.31 KB 388.72 KB +426 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 191.48 KB 191.9 KB +426 Bytes
loader.js 151.04 KB 151.12 KB +78 Bytes
map.js 42.63 KB 42.63 KB No change
matrix.js 128.09 KB 128.09 KB No change
odspDriver.js 150.23 KB 150.23 KB No change
odspPrefetchSnapshot.js 38.39 KB 38.39 KB No change
sharedString.js 148.73 KB 148.73 KB No change
Total Size 1.24 MB 1.24 MB +930 Bytes

Baseline commit: 58e699fea06d56f05dacf0ca3318710911cb466c

Generated by :no_entry_sign: dangerJS against be474a59dc6ca54b8f46430f620c7b9f19cf8adf

msfluid-bot avatar Aug 10 '22 23:08 msfluid-bot

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

github-actions[bot] avatar Aug 11 '22 16:08 github-actions[bot]