FLAML icon indicating copy to clipboard operation
FLAML copied to clipboard
verified publisher icon microsoft

Gpt math solver

Open yiranwu0 opened this issue 2 years ago • 7 comments

Why are these changes needed?

  • When 'messages' in config instead of 'prompt', some messages don't have placeholders, so format it with result error. This change handles this situation
  • Fix typo

Related issue number

Closes #990

Checks

  • [x] I've used pre-commit to lint the changes in this PR, or I've made sure lint with flake8 output is two 0s.
  • [ ] I've included any doc changes needed for https://microsoft.github.io/FLAML/. See https://microsoft.github.io/FLAML/docs/Contribute#documentation to build and test documentation locally.
  • [ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
  • [ ] I've made sure all auto checks have passed.

yiranwu0 avatar Apr 12 '23 02:04 yiranwu0

@kevin666aa please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

yiranwu0 avatar Apr 12 '23 03:04 yiranwu0

Thanks for the contribution. Could you please run pre-commit first: https://microsoft.github.io/FLAML/docs/Contribute#pre-commit to ensure the code passes the "Code formatting" test?

qingyun-wu avatar Apr 12 '23 13:04 qingyun-wu

Add a test case?

qingyun-wu avatar Apr 12 '23 13:04 qingyun-wu

Is this PR intended for merging? If not, please make it a draft.

sonichi avatar Apr 16 '23 08:04 sonichi

Please resolve the conflict.

sonichi avatar Apr 23 '23 04:04 sonichi

Note: No need to review MathVoting.py and functions related to voting in main for now.

yiranwu0 avatar Apr 23 '23 21:04 yiranwu0

Some suggestions about the naming before merging: Folder name: math_solver -> math MathSolver.py -> math_solver.py MathVoting.py -> math_voting.py QueryHandler.py -> query_handler.py

And move math_util.py to the math folder? @sonichi Please feel free to suggest if you have any opinions.

qingyun-wu avatar Apr 23 '23 22:04 qingyun-wu