EdgeML icon indicating copy to clipboard operation
EdgeML copied to clipboard

port code to tensorflow2.0

Open punitvara opened this issue 6 years ago • 6 comments

Compile and run code with tf2.0. Eager execution is disabled. Tested code with python 3.5

Signed-off-by: Punit Vara [email protected]

punitvara avatar May 20 '19 08:05 punitvara

Either #86 or this PR should get merged. Preferably this one. @adityakusupati Can you please review this ?

punitvara avatar May 20 '19 08:05 punitvara

I will try to set it up next week and test it out. @metastableB and @harsha-simhadri any thoughts? I think this is important for tf 2.0 transition.

adityakusupati avatar May 24 '19 11:05 adityakusupati

@punitvara , a couple of things

  1. Bonsai example runs fine, but FastCells don't
  2. Can you isolate the changes you made from the original files, this diff is very cumbersome to follow?

adityakusupati avatar May 29 '19 16:05 adityakusupati

Ok sure. I will push in tf directory once review is done I will create new PR with tf 2.0

punitvara avatar May 30 '19 06:05 punitvara

@adityakusupati I am of the opinion that we should hold out on this PR for a little bit longer till we have a clear view on what we are going to focus on; eager or static compilation. If you feel like going ahead with supporting static graphs with TF2.0, please do so. You can get a clean diff w.r.t tf/ directory by using the native diff command as explained here. You will have to go through it one file at a tile.

@punitvara Thanks for your contributions!

metastableB avatar May 30 '19 07:05 metastableB

@metastableB I've been doing some work to do a port to tf2 for some functions (not using tf1.compat, but full tf2 with eager execution) I wouldn't mind putting together a PR for the work as I go through. But only if there is interest on your side.

cdknorow avatar Oct 08 '21 20:10 cdknorow