DurableFunctionsMonitor icon indicating copy to clipboard operation
DurableFunctionsMonitor copied to clipboard

dotnet 8 support in isolated mode

Open lkurzyniec opened this issue 1 year ago • 15 comments

The selected version '.NET 7 Isolated' will deprecate on 5/14/2024. Please consider updating it soon.Learn more

lkurzyniec avatar Feb 27 '24 15:02 lkurzyniec

Thanks for the reminder, @lkurzyniec , will certainly take care of this.

scale-tone avatar Feb 29 '24 12:02 scale-tone

Seriously? This needs to be high prio! .Net 7 is a Maintenance release that many cannot use.

mronnblom-ith avatar Apr 16 '24 15:04 mronnblom-ith

Hello @mronnblom-ith , to clarify: .NET versions are backward-compatible. So nothing prevents you to inject the current DfMon Isolated package into your .NET 8 projects (in which case it is .NET 8 that will be actually used, of course).

The primary reason for keeping DfMon on older .NET versions up to the last moment is to support those who for whatever reason are not yet able to migrate their codebases.

scale-tone avatar Apr 16 '24 17:04 scale-tone

Ok, that is reasonable. It is probably the AspNet Core integration incompatibility that is causing my problems then, not the .Net version.

mronnblom-ith avatar Apr 16 '24 20:04 mronnblom-ith

I'm using standalone isolated version, and it's not working with .NET 8 Isolated .NET version of Function App.

lkurzyniec avatar May 02 '24 10:05 lkurzyniec

@lkurzyniec , can you please provide more details? How exactly is it not working?

scale-tone avatar May 02 '24 11:05 scale-tone

I have a working version on .NET 7 Isolated.

When I changed to .NET 8 Isolated, it stops working.

Error details Encountered an error (InternalServerError) from host runtime.

lkurzyniec avatar May 06 '24 13:05 lkurzyniec

@lkurzyniec , I confirm there seems to be an issue like that on a Linux platform. When deploying an empty .NET Isolated project targeting .NET 7 and then changing .NET version to 8 in the instance's settings, the app fails to work until you change TargetFramework to net8.0 in CSPROJ file and redeploy.

On a Windows instance (the one which you'd get by deploying the included ARM template) this does not happen though - DfMon Isolated works fine.

scale-tone avatar May 06 '24 17:05 scale-tone

When creating it from scratch in .NET 8 Isolated, the problem is the same.

lkurzyniec avatar May 07 '24 06:05 lkurzyniec

Anyway, this 6.5.0-beta2 package should work (as it targets .NET 8).

Can you please check?

scale-tone avatar May 13 '24 09:05 scale-tone

It's working 🚀 Now I can wait for a stable release of the package, and then I will close that issue. Thx for that 💪🏼

lkurzyniec avatar May 13 '24 16:05 lkurzyniec

It would be nice to bump Azure.Identity as version 1.10.4 is vulnerable.

lkurzyniec avatar May 14 '24 21:05 lkurzyniec

@scale-tone here is PR: https://github.com/microsoft/DurableFunctionsMonitor/pull/179

lkurzyniec avatar May 17 '24 06:05 lkurzyniec

Thanks a lot for your PR, @lkurzyniec !

Typical trouble with massive package bump-ups is that it often breaks things, sometimes in very unexpected places. E.g. here is an example of Microsoft.IdentityModel.Protocols.OpenIdConnect.

And sadly here in DfMon, with all its incarnations, all these numerous ways of running it, all various platforms and pricing tiers, we do not have a 100% reliable auto-tests. So I will have to manually and gradually apply your changes, to check that nothing gets broken. Please, give me some time for that...

scale-tone avatar May 18 '24 18:05 scale-tone

Got it. I didn't think that upgrading the version could be so risky and painful. I thought it is a matter of building the projects.

lkurzyniec avatar May 18 '24 19:05 lkurzyniec

@scale-tone any ETA for a new stable version?

lkurzyniec avatar Jun 10 '24 12:06 lkurzyniec

Done

scale-tone avatar Jun 30 '24 18:06 scale-tone