microsoft
Strip struct, entry and groupshared names from DXIL
Strip struct, entry and groupshared names from DXIL when stripping reflection data. https://github.com/microsoft/DirectXShaderCompiler/issues/7627
:white_check_mark: With the latest revision this PR passed the C/C++ code formatter.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@llvm-beanz Updated based on the review. Let me know if this is what you meant by using a separate pass. If not, please provide some guidance as to where and how it should work.
Refactored the pass to roughly where advised and the functionality seems to still work and my tests pass, however CompilerTest::CompileThenTestPdbUtils is now failing. Since you've mentioned wanting to take a look at the tests later this week, I've left it in a failing state since I'm not sure what the interplay is between the passes and those tests with regards to data stripping, i.e. it could be that the failing test needs updating but also that my changes are wrong.
Synced up to main. @llvm-beanz let me know if you need anything from me regarding those tests
@llvm-beanz - have you had a chance to double check your feedback has been addressed?
@GlassBeaver - could you add something to ReleaseNotes.md documenting this change please?
