DirectXShaderCompiler icon indicating copy to clipboard operation
DirectXShaderCompiler copied to clipboard

[SPIRV] Do not create counter for RWStructuredBuffer by default

Open greg-lunarg opened this issue 3 years ago • 2 comments

Defer creating counter for RWSBuffer until Inc/DecrementCounter method is invoked.

Fixes #4569

greg-lunarg avatar Aug 11 '22 21:08 greg-lunarg

:white_check_mark: Build DirectXShaderCompiler 1.0.1905 completed (commit https://github.com/microsoft/DirectXShaderCompiler/commit/403dcebf62 by @greg-lunarg)

AppVeyorBot avatar Aug 11 '22 23:08 AppVeyorBot

@Keenuts Can you please review?

greg-lunarg avatar Aug 12 '22 19:08 greg-lunarg

Thanks for fixing that! Shouldn't we also try to fix spirv-opt DCE issue while we have a repro? Maybe the bug causing counters not to be cleaned is also impacting other things?

OK. I will create a SPIRV-Tools issue at your request.

greg-lunarg avatar Aug 15 '22 17:08 greg-lunarg

:white_check_mark: Build DirectXShaderCompiler 1.0.1915 completed (commit https://github.com/microsoft/DirectXShaderCompiler/commit/c2e776f604 by @greg-lunarg)

AppVeyorBot avatar Aug 15 '22 21:08 AppVeyorBot

@Keenuts I believe I have addressed all your current issues. Please review.

greg-lunarg avatar Aug 15 '22 22:08 greg-lunarg

Thanks for approval. I do not have merge permission on this repo, so I you could please merge, that would be appreciated.

greg-lunarg avatar Aug 16 '22 16:08 greg-lunarg