DirectXShaderCompiler icon indicating copy to clipboard operation
DirectXShaderCompiler copied to clipboard
verified publisher icon microsoft

Fix the SAL of IDxcResult::GetOutput

Open gongminmin opened this issue 3 years ago • 2 comments

The ppOutputName parameter can be nullptr and can return nullptr. Change its SAL to COM_Outptr_opt_result_maybenull.

Related to #4149 .

gongminmin avatar May 29 '22 23:05 gongminmin

:white_check_mark: Build DirectXShaderCompiler 1.0.1719 completed (commit https://github.com/microsoft/DirectXShaderCompiler/commit/3ad8d79b60 by @gongminmin)

AppVeyorBot avatar May 30 '22 00:05 AppVeyorBot

Hey @adam-yang , just hit this locally myself after moving to the 2207 bits, any idea who can review this?

sausag3 avatar Aug 20 '22 06:08 sausag3