DevSkim icon indicating copy to clipboard operation
DevSkim copied to clipboard

Oficial docker image?

Open omerlh opened this issue 7 years ago • 13 comments

Is there a plan to have an official docker image for the CLI?

omerlh avatar Oct 04 '18 12:10 omerlh

@omerlh this is not an official docker image. But might suit your needs https://github.com/patros/docker-devskim

coderpatros avatar May 14 '19 14:05 coderpatros

:+1:

I would like to be able to provide this in our CI pipelines as well as allowing developers to include it in their IDE.

jhulten avatar Sep 17 '19 20:09 jhulten

@jhulten what IDE do they use? There is already extensions for Visual Studio and VS Code.

And if you use my docker image you can "break" the build based on the exit code. I'm currently using it across about 200 repos.

coderpatros avatar Sep 17 '19 23:09 coderpatros

We have some in VSCode, VS, Atom, and Sublime with a couple of JetBrains products in the mix.

Your image is great, but it will be easier to get through security if it is mainstreamed.

Good exit codes would also allow pre-commit hooks via https://pre-commit.com/

jhulten avatar Sep 22 '19 00:09 jhulten

Oh, that's simple @jhulten. My Dockerfile and DevSkim are MIT licenced. Take a cut of them and build your own internal image. That way you have full control over it which should keep the security team happy.

coderpatros avatar Sep 23 '19 11:09 coderpatros

For anyone interested. My docker image is now building directly from this repo instead of my custom fork. @gfs any interest in a pull request for a Dockerfile?

coderpatros avatar Jan 23 '20 09:01 coderpatros

I’d be interested to take a look. Feel free to open a PR.

On Thu, Jan 23, 2020 at 1:30 AM, Patrick Dwyer [email protected] wrote:

For anyone interested. My docker image is now building directly from this repo instead of my custom fork. @gfs any interest in a pull request for a Dockerfile?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

gfs avatar Jan 23 '20 14:01 gfs

We are now planning to make an official docker image. We are currently working on completely rewriting the build pipeline, and this task relies on #86 to complete.

gfs avatar Feb 11 '20 18:02 gfs

We hit some delays in getting the rest of our CI pipeline running. We've now completed that. This is still coming soon.

gfs avatar Feb 25 '20 17:02 gfs

We are now also distributing devskim as a dotnet global tool. That may help in the meantime with a single line install (as long as you have .net core 3.1 installed)

dotnet tool install --global devskim

That will place the devskim cli on your path.

gfs avatar Feb 28 '20 18:02 gfs

In case there is anyone following this who uses my docker image. I’ve switched it over to using the official build via dotnet tool install.

coderpatros avatar Mar 04 '20 08:03 coderpatros

In case there is anyone following this who uses my docker image. I’ve switched it over to using the official build via dotnet tool install.

Quick update, the dotnet tool has been moved here: https://www.nuget.org/packages/Microsoft.CST.DevSkim.CLI

The tool can be executed via the "devskim" command.

daalcant avatar Mar 06 '20 04:03 daalcant

Thanks for the heads up @daalcant

coderpatros avatar Mar 06 '20 07:03 coderpatros