DeepSpeed icon indicating copy to clipboard operation
DeepSpeed copied to clipboard

Rename config parameters for pydantic v2 changes

Open loadams opened this issue 2 years ago • 2 comments

PyDantic is preparing to update to v2 and we need to add support for their breaking changes from their migration plan.

loadams avatar Apr 18 '23 15:04 loadams

Looks like v2 will not be compatible with v1 - we will need to add pydantic>=2.0.0 to requirements once we make the switch. It might be worth adding pydantic<2.0.0 to the requirements before that time.

mrwyattii avatar Apr 18 '23 16:04 mrwyattii

Looks like v2 will not be compatible with v1 - we will need to add pydantic>=2.0.0 to requirements once we make the switch. It might be worth adding pydantic<2.0.0 to the requirements before that time.

Makes sense, I was going to wait for the change then complete this PR, but probably better to do it in a controlled way, so this PR can keep us from breaking then we can complete this one when needed after.

loadams avatar Apr 18 '23 16:04 loadams