DeepSpeed icon indicating copy to clipboard operation
DeepSpeed copied to clipboard

Remove deprecated `torch._six` imports

Open yasyf opened this issue 2 years ago • 3 comments

Closes #2845.

yasyf avatar Feb 20 '23 22:02 yasyf

@microsoft-github-policy-service agree

yasyf avatar Feb 20 '23 22:02 yasyf

@yasyf we currently recommend users use torch 1.8+, it appears this older version of torch does not allow from torch import inf. Perhaps we can change these imports to be dependent on torch version? Not sure what version of torch this was supported, I just tried on 1.13 and it works there.

jeffra avatar Feb 21 '23 20:02 jeffra

@jeffra godo catch! it's only a problem if you're using pytorch 2.0.0+ (nightly). I'll make it conditional

yasyf avatar Feb 21 '23 23:02 yasyf

@jeffra test failure seems unrelated?

yasyf avatar Feb 23 '23 05:02 yasyf