DeepSpeed icon indicating copy to clipboard operation
DeepSpeed copied to clipboard
verified publisher icon microsoft

Share a list of weight attributes instead of a single one in TiedLayerSpec API

Open thomasw21 opened this issue 3 years ago • 2 comments

thomasw21 avatar Jun 21 '22 09:06 thomasw21

@thomasw21, thanks for the PR and apologies for the delay in reviewing. Can you please provide a clarification? It seems there are two issues being addressed in this PR: (1) supporting user-specified forward function and (2) list of weight attributes. If this is correct, I think it might be better to split into two separate PRs. What do you think? Thanks!

tjruwase avatar Jul 27 '22 14:07 tjruwase

Indeed! Sorry I've sort of dropped this as well currently, as we've been focusing on other aspects of BigScience. I'll try split the PRs when I get the chance! My bad!

thomasw21 avatar Jul 27 '22 14:07 thomasw21

@tjruwase Are these changes we still want? If so I can revive them with the current develop branch.

jomayeri avatar Aug 25 '23 23:08 jomayeri

@tjruwase Are these changes we still want? If so I can revive them with the current develop branch.

@thomasw21, are you still interested in this PR? Are you fine with #4216 replacing this?

tjruwase avatar Aug 28 '23 15:08 tjruwase

Hey! I'm fine with #4216 overriding this PR :D

thomasw21 avatar Aug 28 '23 15:08 thomasw21