Deep3DFaceReconstruction icon indicating copy to clipboard operation
Deep3DFaceReconstruction copied to clipboard
verified publisher icon microsoft

There maybe a mistake in the code

Open MSKTHU opened this issue 5 years ago • 2 comments

At line 134 and 135, reconstruct_mesh.py:

a1 = 2*np.pi/np.sqrt(3.0)
a2 = 2*np.pi/np.sqrt(8.0)

I think the two np.sqrts are incorrectly added here. Please have a check.

MSKTHU avatar Mar 23 '20 09:03 MSKTHU

At line 134 and 135, reconstruct_mesh.py:

a1 = 2*np.pi/np.sqrt(3.0)
a2 = 2*np.pi/np.sqrt(8.0)

I think the two np.sqrts are incorrectly added here. Please have a check.

I think you are right, a1 is actually A_1^{hat} from An Efficient Representation for Irradiance Environment Maps. I have been checking this out for the whole morning.

loja342 avatar May 29 '20 07:05 loja342

At line 134 and 135, reconstruct_mesh.py:

a1 = 2*np.pi/np.sqrt(3.0)
a2 = 2*np.pi/np.sqrt(8.0)

I think the two np.sqrts are incorrectly added here. Please have a check.

I think you are right, a1 is actually A_1^{hat} from An Efficient Representation for Irradiance Environment Maps. I have been checking this out for the whole morning.

但是加不加好像结果都差球不多....

MSKTHU avatar May 29 '20 07:05 MSKTHU