CDM icon indicating copy to clipboard operation
CDM copied to clipboard
verified publisher icon microsoft

resolve options and deprecation warnings

Open apisarenco opened this issue 3 years ago • 3 comments

This PR addresses 2 issues:

  1. ResolveOptions is used in code, but it was only imported when TYPE_CHECKING. This caused calls to attribute.fetch_object_definition() to fail.
  2. Switch from doc.namespace and doc.folder_path usage to doc.owner.namespace and doc.owner.folder_path, as the deprecation warnings suggested.

apisarenco avatar Jun 27 '22 21:06 apisarenco

CLA assistant check
All CLA requirements met.

ghost avatar Jun 27 '22 21:06 ghost

Any update on this PR?

jaja-git avatar Sep 27 '22 08:09 jaja-git

Hi @apisarenco and @jaja-git, thanks for your interest in contributing to the CDM project. We are evaluating the changes internally. Once a final decision has been made, we will get back with the next steps.

Venkata1920 avatar Oct 06 '22 18:10 Venkata1920