CCF icon indicating copy to clipboard operation
CCF copied to clipboard

`LOG_FATAL_FMT` is not fatal

Open letmaik opened this issue 4 years ago • 2 comments

It simply throws an exception which may or may not be caught in upper levels.

This is in contrast to the description of the log level:

FATAL, // fatal errors that lead to a termination of the program/enclave

letmaik avatar Dec 17 '21 16:12 letmaik

It shouldn't even throw, and it should not try to terminate in a way that somehow works in any context or anything like that. FATAL is a log level, like DEBUG, or INFO, this is a logging and it logs at that level.

achamayou avatar Jan 11 '22 15:01 achamayou

I corrected the comment on this recently, but the host-side implementation will still throw. We should remove that behaviour, and add a throw or abort if appropriate at each calling point.

eddyashton avatar Jul 20 '22 15:07 eddyashton