BotFramework-WebChat icon indicating copy to clipboard operation
BotFramework-WebChat copied to clipboard

Added conditional check for tabindex in focusRedirector

Open amirmursal opened this issue 1 year ago • 1 comments

Fixes #5047

Changelog Entry

Fixes [#5047] Added conditional check for tabindex in focusRedirector [#5223], by @amirmursal

Description

Talkback is announcing empty div while moving to next message. This fixed after refactoring the FocusRedirector component

  • [x] I have added tests and executed them locally
  • [x] I have updated CHANGELOG.md
  • [ ] I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • [x] Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • [ ] Browser and platform compatibilities reviewed
  • [ ] CSS styles reviewed (minimal rules, no z-index)
  • [ ] Documents reviewed (docs, samples, live demo)
  • [ ] Internationalization reviewed (strings, unit formatting)
  • [ ] package.json and package-lock.json reviewed
  • [ ] Security reviewed (no data URIs, check for nonce leak)
  • [ ] Tests reviewed (coverage, legitimacy)

amirmursal avatar Jun 26 '24 04:06 amirmursal

Please fix tests

OEvgeny avatar Jun 26 '24 16:06 OEvgeny