BotFramework-WebChat icon indicating copy to clipboard operation
BotFramework-WebChat copied to clipboard

Unnecessary ARIA attributes in Keyboard Controls section.

Open cryptasian opened this issue 2 years ago • 1 comments

Is it an issue related to Adaptive Cards?

No.

What is the PWD impact?

No response

What browsers and screen readers do this issue affect?

No response

Are there any code-based customization done to Web Chat?

No, I am using Web Chat without any customizations except "styleOptions".

What version of Web Chat are you using?

Latest production

Which area does this issue affect?

ARIA roles

What is the public URL for the website?

https://edfinancial.com

How to reproduce the issue?

This is feedback from the accessibility company Allyant who has been testing our website and has people who use screenreaders and other assistive technologies as a part of their testing team.

The presence of an unnecessary ARIA attribute can create unexpected behavior across various configurations. unnecessary-aria-dialog-role

What do you expect?

The presence of an unnecessary ARIA attribute can create unexpected behavior across various configurations. Remove the role=dialog and aria-labelledby attribute from each element.

What actually happened?

See other responses.

Do you have any screenshots or recordings to repro the issue?

No response

Did you find any DOM elements that might have caused the issue?

No response

MAS reference

No response

WCAG reference

https://www.w3.org/WAI/WCAG22/Understanding/name-role-value

WAI-ARIA reference

No response

Adaptive Card JSON

No response

Additional context

No response

cryptasian avatar Dec 29 '23 20:12 cryptasian

The keyboard help screen is a modal. role="dialog" is a reasonable way to identify this modal. And the aria-labelledby is pointing to the title of the dialog.

We are following this APG when building the keyboard help screen, https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/dialog/.

Will be great if you can give more context on the issue.

compulim avatar Mar 30 '24 18:03 compulim