BotFramework-WebChat icon indicating copy to clipboard operation
BotFramework-WebChat copied to clipboard

Uses `claimInterpreter`

Open compulim opened this issue 2 years ago • 0 comments

Fixes #4870.

Changelog Entry

Fixed

  • Fixes #4870. Originator should use claimInterpreter instead of ReplyAction/provider, by @compulim, in PR #4910

Description

Instead of using a ReplyAction/provider to specify the originator, we should use Claim/claimInterpreter. This allows every claim to have their own originator.

Specific Changes

  • Moved Schema.org types to botframework-webchat-core
  • Modified Schema.org type helpers: type is only needed for first-level things in Activity.entities
  • [x] I have added tests and executed them locally
  • [x] I have updated CHANGELOG.md
  • [x] I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • [x] ~Accessibility reviewed (tab order, content readability, alt text, color contrast)~
  • [x] ~Browser and platform compatibilities reviewed~
  • [x] ~CSS styles reviewed (minimal rules, no z-index)~
  • [x] ~Documents reviewed (docs, samples, live demo)~
  • [x] ~Internationalization reviewed (strings, unit formatting)~
  • [x] ~package.json and package-lock.json reviewed~
  • [x] ~Security reviewed (no data URIs, check for nonce leak)~
  • [x] Tests reviewed (coverage, legitimacy)

compulim avatar Oct 18 '23 01:10 compulim