BotFramework-WebChat
BotFramework-WebChat copied to clipboard
Upgrade CLDR to v37 and remove adopted cldr-data* packages
Fixes #4403. Related to #3998.
Changelog Entry
Fixed
- Fixes #4403. Bump to CLDR v37 and remove adopted
cldr-dataandcldr-data-downloaderpackages, by @compulim, in PR #4874
Description
We are bumping CLDR to v37 from the official Unicode repository, despite the current is v43.
We adopted cldr-data and cldr-data-downloader to fix their vulnerabilities and patching plurals for Polish and Portuguese language (bug of CLDR v36). However, we no longer need both packages as we download from the official Unicode repository.
Design
globalize does not support CLDR v38 or up due to new "c" parameter added to French plurals and globalize did not update its dependency on make-plural package. Thus, we cannot bump to v38 or beyond until globalize resolved the issue.
Specific Changes
- Imports CLDR from
cldr-coreand other packages - Removes
cldr-dataandcldr-data-downloader - Moved Polish and Portuguese plurals patch to
createPrecompileGlobalizescript
- [x] I have added tests and executed them locally
- [x] I have updated
CHANGELOG.md - [x] I have updated documentation
Review Checklist
This section is for contributors to review your work.
- [x] ~Accessibility reviewed (tab order, content readability, alt text, color contrast)~
- [x] ~Browser and platform compatibilities reviewed~
- [x] ~CSS styles reviewed (minimal rules, no
z-index)~ - [x] ~Documents reviewed (docs, samples, live demo)~
- [x] Internationalization reviewed (strings, unit formatting)
- [x]
package.jsonandpackage-lock.jsonreviewed~ - [x] ~Security reviewed (no data URIs, check for nonce leak)~
- [x] Tests reviewed (coverage, legitimacy)