BotFramework-WebChat icon indicating copy to clipboard operation
BotFramework-WebChat copied to clipboard

Remove deprecated code related to activity middleware

Open compulim opened this issue 3 years ago • 0 comments

(This is a continuation work of #4362)

Feature Request

activityRenderer, activityStatusRenderer, and attachmentRenderer props

The deprecation period of activityRenderer, activityStatusRenderer, and attachmentRenderer props is up on 2022-06-15. We should remove them to simplify our code.

nextVisibleActivity

The deprecation period of nextVisibleActivity is up on 2022-07-22. We should remove nextVisibleActivity to simplify our code.

While removing the nextVisibleActivity, also clean up some of our samples to make sure:

() => next => ({ activity, nextVisibleActivity }) => {
  return next({ activity, nextVisibleActivity });
}

To become:

() => next => (...args) => {
  return next(...args);
}

This clean up make sure activity middleware is upgradeable.

Move to freezeArray from Object.freeze() for some typed arrays

With the ordinary Object.freeze, it types out as by generalizing types for all items.

Object.freeze(['abc', 123]); // (number | string)[]

With freezeArray, it does not generalize types for all items.

freezeArray(['abc', 123]); // [string, number]

[feature-request]

compulim avatar Jul 29 '22 20:07 compulim