BotFramework-WebChat icon indicating copy to clipboard operation
BotFramework-WebChat copied to clipboard

Bot Framework Emulator - Audio card -image is not displaying.

Open rvinothrajendran opened this issue 5 years ago • 12 comments

Version

4.9.0

Describe the bug

Audio card -image is not displaying.

Steps to reproduce

Try the Audio Card sample with image.

Expected behavior

Image should be display

Screenshots

image

rvinothrajendran avatar Jul 19 '20 02:07 rvinothrajendran

Thank you for the report, @rvinothrajendran

Would you kindly link to the sample you're referring to, and provide some code that reproduces the issue?

v-kydela avatar Jul 21 '20 18:07 v-kydela

@v-kydela Kindly find the sample here : https://github.com/rvinothrajendran/BotTutorialSample/tree/master/Python_tutorial/18-AudioCard/audiocard

rvinothrajendran avatar Jul 22 '20 02:07 rvinothrajendran

@compulim - I have confirmed that audio card images do not render in Web Chat or Emulator, and it's not because of the SVG. JPG images also do not render. (This has nothing to do with the bot being written in Python, of course.) I will transfer this to you.

v-kydela avatar Jul 22 '20 23:07 v-kydela

@compulim : Any updates?

daveta avatar Aug 03 '20 18:08 daveta

@compulim are you able to take a look into this one?

peterinnesmsft avatar Aug 14 '20 18:08 peterinnesmsft

I believe this is a feature we missed.

compulim avatar Sep 01 '20 18:09 compulim

@v-kydela Web Chat is equipped to handle Audio Cards with images; however, DirectLineJs is not. https://github.com/microsoft/BotFramework-DirectLineJS/issues/180

tdurnford avatar Sep 14 '20 16:09 tdurnford

So to clarify, @tdurnford, Web Chat currently supports this with Bots connected via DirectLine?

If that's the case, there's basically a lack of parity here between Emulator and Web Chat and the ask would be to implement images with audio cards in the Emulator?

tonyanziano avatar Sep 14 '20 20:09 tonyanziano

@tonyanziano Not quite. If Web Chat receives an Audio Card with an image, it will render the poster correctly. However, if the bot sends an Audio Card with an image and it is sent through DirectLine, DirectLine will remove the image. Web Chat/DirectLineJs and the Emulator current exhibit the same behavior.

Additional Context

https://github.com/microsoft/BotFramework-WebChat/blob/1559ab52158e1b3d0e523d1c2b8b66c462e0494c/packages/bundle/src/adaptiveCards/Attachment/AudioCardContent.js#L21

tdurnford avatar Sep 14 '20 21:09 tdurnford

I believe this is blocked by https://github.com/microsoft/BotFramework-DirectLineJS/issues/180, confirm? Mark DLJS issue as bug? Assigning to @Kaiqb for visibility

corinagum avatar Jan 13 '21 01:01 corinagum

@corinagum this is also related to https://github.com/microsoft/BotFramework-DirectLineJS/issues/255.

compulim avatar Feb 19 '21 19:02 compulim

@compulim I see that https://github.com/microsoft/BotFramework-DirectLineJS/issues/255 is scheduled to ship on R13. ASsuming that is the case, would this be also addressed in R13?

carlosscastro avatar Mar 26 '21 17:03 carlosscastro