BotBuilder-Samples icon indicating copy to clipboard operation
BotBuilder-Samples copied to clipboard

Cleanup csharp_dotnetcore/49.qnamaker-all-features

Open stevengum opened this issue 4 years ago • 0 comments

Sample information

csharp_dotnetcore/49.qnamaker-all-features

Tasks

  • Cleanup or delete QnAMakerBaseDialog.cs as applicable
  • Cleanup or delete BotServices.cs and any references to BotServices as applicable
  • Other applicable cleanup as determine by a more experienced .NET developer

The three overrides below are unnecessary or missing functionality compared to what's in the latest release of the SDK.

https://github.com/microsoft/BotBuilder-Samples/blob/c819a27b3d23a909cb106a741f8aad45c6f44a0f/samples/csharp_dotnetcore/49.qnamaker-all-features/Dialog/QnAMakerBaseDialog.cs#L41

SDK: GetQnAMakerClientAsync tries to populate the QnAMakerClient with an HttpClient (more performant) and also configures telemetry for the client.

https://github.com/microsoft/BotBuilder-Samples/blob/c819a27b3d23a909cb106a741f8aad45c6f44a0f/samples/csharp_dotnetcore/49.qnamaker-all-features/Dialog/QnAMakerBaseDialog.cs#L41

SDK: GetQnAMakerOptionsAsync uses QnAMakerMetadata filters, adds the QnARequestContext and doesn't set RankerType to a magic string.

https://github.com/microsoft/BotBuilder-Samples/blob/c819a27b3d23a909cb106a741f8aad45c6f44a0f/samples/csharp_dotnetcore/49.qnamaker-all-features/Dialog/QnAMakerBaseDialog.cs#L58

SDK code: GetQnAResponseOptionsAsync does everything the sample's override does, thus the override is unnecessary.

stevengum avatar Mar 28 '21 02:03 stevengum