BotBuilder-Samples icon indicating copy to clipboard operation
BotBuilder-Samples copied to clipboard

Skill bot should create eoc as an activity, as IEndOfConversation doesn't have a Value property

Open JonathanFingold opened this issue 4 years ago • 2 comments

Sample information

  1. Sample type: [samples]
  2. Sample language: [dotnetcore]
  3. Sample name: 80.skills-simple-bot-to-bot/EchoSkillBot (probably in sample 81, too)

Describe the bug

With the current code, need to jump through hoops to set the Value property on the end of conversation activity. This is an issue because we tell developers to use the Value property as return value when the skill ends.

To Reproduce

Steps to reproduce the behavior:

  1. Edit the skill bot in the simple skill sample.
  2. After creating the end of conversation activity (as written in the sample), try to assign to its value property.
  3. See error (compiler warning, as there is no such property on the IEndOfConversation type).

Expected behavior

Can assign a value to the activity.

Additional context

https://github.com/microsoft/BotBuilder-Samples/blob/492bbc16c09998efcf935055b2378822373464f0/samples/csharp_dotnetcore/80.skills-simple-bot-to-bot/EchoSkillBot/Bots/EchoBot.cs#L17-L22

JonathanFingold avatar Feb 18 '21 19:02 JonathanFingold

After talking to Srinaath and TJ, it looks like the end dialog action in the skill does generate an endOfConversation activity, and there is a way to set the generated activity value property. There doesn't seem to be a way to set the generated activity code property, however.

JonathanFingold avatar Mar 04 '21 16:03 JonathanFingold