BotBuilder-Samples icon indicating copy to clipboard operation
BotBuilder-Samples copied to clipboard

Please update all adaptive samples to match the dialog pattern in the C# 01 sample

Open JonathanFingold opened this issue 5 years ago • 1 comments

Github issues for C# /JS / Java/ Python should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Sample information

  1. Sample type: [\samples]
  2. Sample language: [dotnetcore][nodejs]
  3. Sample name: all

Describe the bug

Give a clear and concise description of what the bug is.

  1. The original pattern is confusing: root dialog is a component dialog with just one adaptive dialog (they are both container dialogs).
  2. I "fixed" the pattern in the BotBuilder-Samples/samples/csharp_dotnetcore/adaptive-dialog/01.multi-turn-prompt/ sample.
  3. Only use an outer component dialog if it's necessary, which may or may not be the case for the 04.waterfall-or-custom-dialog-with-adaptive sample.
  4. One other fix that @johnataylor pointed out, the bot implementation does not use any of the features of the activity handler and so should not derive from the activity handler.

Expected behavior

Give a clear and concise description of what you expected to happen.

I wanted a pattern that made sense to document.

Additional context

PRs #2475 and #2569 contain my changes to the 01 sample.

[bug]

JonathanFingold avatar Jul 13 '20 18:07 JonathanFingold

PS. We no longer pretend we support adaptive dialogs development in SDK-first bots, and we now have package samples specifically for Composer. However, https://github.com/microsoft/BotBuilder-Samples/tree/main/experimental/adaptive-dialog/javascript_nodejs still exists, so leaving this open for now.

JonathanFingold avatar Jan 06 '22 17:01 JonathanFingold