BotBuilder-Samples icon indicating copy to clipboard operation
BotBuilder-Samples copied to clipboard

Lack of parity in scaleout BlobStore class (C# vs Python)

Open JonathanFingold opened this issue 5 years ago • 1 comments

Sample information

  1. Sample type: [\samples]
  2. Sample language: [dotnetcore,ptyhon]
  3. Sample name: 42.scaleout

Describe the bug

In C#, BlobStore.SaveAsync returns true or false, depending on whether the write with ETag succeeds. In Python, BlobStore.save always returns true.

To Reproduce

Steps to reproduce the behavior:

  1. Compare the two implementations of the save operation:
  2. Error: note that there appears to be logic missing from the Python implementation.

Expected behavior

All versions of the sample implement nearly identical behavior [as much as possible].

Additional context

Opened as part of trying to address doc issue 1717. [bug]

JonathanFingold avatar May 26 '20 23:05 JonathanFingold

I can look into this. There's something else I was looking at for this sample concerning it's dependencies.

jwiley84 avatar May 27 '20 16:05 jwiley84

Closing this issue.

The SDK Team is planning to retire the Bot Framework Python SDK. No new features, but we'll cover critical fixes until then.

For new bots, give Power Virtual Agents or Bot Framework's C# or JavaScript SDKs a whirl. They're our go-to now.

Cheers!

ram-xv avatar May 23 '23 22:05 ram-xv