ApplicationInsights-Java
ApplicationInsights-Java copied to clipboard
feat: fixed leak
Fix # leaks in unit test
For significant contributions please make sure you have completed the following items:
- [ ] Design discussion issue #
- [ ] Changes in public surface reviewed
- [ ] CHANGELOG.md updated
@vcharmcaster please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]Options:
- (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
- (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"Contributor License Agreement
@microsoft-github-policy-service agree
hi @vcharmcaster, I'd suggest reverting the try-with-resources around the (mock) exporters, since those are known to not require closing, and avoids additional indentation.
then will review the remaining, thx!
updated