AdaptiveCards icon indicating copy to clipboard operation
AdaptiveCards copied to clipboard

[Spec] Plan for updating the FactSet element

Open almedina-ms opened this issue 3 years ago • 4 comments

Related Issue

Proposal for a long lasting fix for https://microsoft.visualstudio.com/OS/_workitems/edit/37990023

Description

Add details of how to update the FactSet element to provide a general better experience for car authors

Microsoft Reviewers: Open in CodeFlow

almedina-ms avatar Jun 10 '22 17:06 almedina-ms

If FactSet's title and value have all of the properties of TextBlock, we can also use TextBlocks as values of FactSet's title and value.

With this change, I'm wondering what benefits cards authors get when they can use Tables with TextBlocks.

I think factset cover only the scenario where you want a 2 by N table

almedina-ms avatar Jun 10 '22 18:06 almedina-ms

If FactSet's title and value have all of the properties of TextBlock, we can also use TextBlocks as values of FactSet's title and value. With this change, I'm wondering what benefits cards authors get when they can use Tables with TextBlocks.

I think factset cover only the scenario where you want a 2 by N table

Yes, you are correct. I like the changes. My humble suggestion is we can also consider factoring out text properties and create a new property that holds all of the text properties as we do with Background Property. And add the property to TextBlock and FactSet.

jwoo-msft avatar Jun 10 '22 22:06 jwoo-msft

If FactSet's title and value have all of the properties of TextBlock, we can also use TextBlocks as values of FactSet's title and value. With this change, I'm wondering what benefits cards authors get when they can use Tables with TextBlocks.

I think factset cover only the scenario where you want a 2 by N table

Yes, you are correct. I like the changes. My humble suggestion is we can also consider factoring out text properties and create a new property that holds all of the text properties as we do with Background Property. And add the property to TextBlock and FactSet.

I think this is done in code in the shared model for TextBlock and TextRuns, do you want to open that paradigm to the format of the card?

almedina-ms avatar Jun 13 '22 17:06 almedina-ms

Hi @almedina-ms. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

ghost avatar Jun 19 '22 16:06 ghost