GmsCore icon indicating copy to clipboard operation
GmsCore copied to clipboard

Implement SplitInstallService

Open DaVinci9196 opened this issue 1 year ago • 7 comments

Fix maps language modification and Fix Smart Lens translation language download

DaVinci9196 avatar Aug 19 '24 11:08 DaVinci9196

Will it fix https://github.com/microg/GmsCore/issues/1629 and partially resolve https://github.com/microg/GmsCore/issues/2225?

CoelacanthusHex avatar Aug 19 '24 11:08 CoelacanthusHex

This PR seems to be mixing completely unrelated features (Phenotype / Experiment Flags and SplitInstallService). I don't think SplitInstallService strictly needs Phenotype related functionality. Please clean this up so the PR only contains the SplitInstallService

mar-v-in avatar Aug 19 '24 17:08 mar-v-in

This PR seems to be mixing completely unrelated features (Phenotype / Experiment Flags and SplitInstallService). I don't think SplitInstallService strictly needs Phenotype related functionality. Please clean this up so the PR only contains the SplitInstallService

I submitted a new revision

DaVinci9196 avatar Aug 21 '24 14:08 DaVinci9196

We modified it according to your opinion

DaVinci9196 avatar Aug 28 '24 13:08 DaVinci9196

@fynngodau Accepted, thanks for the suggestion. In practice, the packageName provided by the calling method cannot be verified by PackageUtils.getAndCheckCallingPackage to be the same calling

DaVinci9196 avatar Sep 12 '24 09:09 DaVinci9196

Thanks for providing us with a new iteration!

I now noticed that HeaderProvider and com.android.vending.extensions are partially overlapping and duplicate, and the latter is not well-integrated with the classes (AuthData and DeviceEnvInfo) used by the former. Would it be possible to harmonize and merge the two files? Though I see the difficulty considering that some calls seem to want an x-ps-rh header and others do not.

Is there a reason you are using 1 instead of the real (microG) Android ID in your queries?

In practice, the packageName provided by the calling method cannot be verified by PackageUtils.getAndCheckCallingPackage to be the same calling

I can't see why it wouldn't work the way you tried, but maybe @mar-v-in has an idea.

fynngodau avatar Sep 14 '24 15:09 fynngodau

I opened PR #2553, which contains the code from this PR; I performed some major refactoring to SplitInstallService there.

fynngodau avatar Sep 22 '24 11:09 fynngodau