"Ask before registering a new app for push notifications" dialog layout is broken

[Wojtaz0w]

Describe the bug Dialog which pops up when an app wants to register for FCM service has its layout broken, it is very narrow.

To Reproduce Steps to reproduce the behavior:

1. Enable "ask before registering a new app to recieve push notifications"
2. Trigger the pop-up
3. See how broken it is

Expected behavior Dialog is wide (normally) like on v0.3.0 of microG.

Screenshots

System Android Version: 14 Custom ROM: crDroid 10.1

Additional context Only happens on microG 0.3.1

[ghost]

@mar-v-in I suspect there are common causes for this issue too https://github.com/microg/GmsCore/issues/2271 In a number of languages, words are longer on average and reading something becomes problematic

[mar-v-in]

This issue is caused by invalid use of dialogs in the updated material design UI toolkit and affects all languages the same (it's also broken in English).

The issue #2271 you mentioned is also related to the new UI toolkit, and beside one issue (that causes a part of the horizontal screen estate to be wasted) is specifically that preference titles are now expected to be single line. This is the case for every preference in the current version AOSP system settings as well. The longterm solution for this is to adjust preference titles to be shorter so it works for every language. AOSP has translator instructions with the respective strings to limit the number of characters, which may mean that translators need to find a different wording that fulfills the requirement, even if less accurate. So we need to do the same. For the specific screen in the screenshot, the preference's description (both title and summary) are not very good anyway and should be redone. There's already some changes for this screen on master for 0.3.2, but definitely should be improved further.

[ghost]

@mar-v-in, Ok I'll try to rephrase where possible. Combined with getting rid of empty space on the left for items without icons it will be enough I hope.

However, I don't completely agree that all those strings must be single line (should be, but not must). For example google, allows line breaks even in settings and its parts

I don't think it looks bad.