Changes to tests can block updates in Firefox

[glennjones]

Hi @dissolve

Looks like you are motoring with your parser and finding all sorts of issues with the tests. Great to see someone putting a lot effort into a parser.

Would just like to point out that the tests are used for automated updating of the microformats-shiv code in the Firefox browser core library. I built Mozilla a script that will not allow them to update the microformats-shiv code without it passing these tests. On a new pull of my code it also converts the tests and adds them to Mozilla's internal test suite. The script pulls the tests directly off this repo. Mozilla only use the parser internally. I am not sure they do new pulls of updated versions of the microformats-shiv anymore.

If there is an issue with the tests they should be changed, I am not saying otherwise, just want to let you known

I would love to help work through the issues you are having with the tests at the moment and check my own parser to understand each problem but I just do not have the time at the moment.

Cheers Glenn

[dissolve]

thanks @glennjones, thats good to know.

I have finally made it through all the issues and now I have at least documented them all, so there shouldn't be any more bugs getting raised from me for a while.

[tantek]

@glennjones do you have time to at least review/accept pull requests for any test-related changes to microformats-shiv parser?

[glennjones]

@tantek would love to, but my work circumstances have changed.

I am back at full-time, plus some. Last week I pulled a 7 day week and its going to be the same this week. Its not that I am dropping my interest in microformats, just a lack of time due to current commercial pressures. This level workload is going with me for the rest of 2017. My open source work and conference going has been very heavily hit across the board. I am already 3 month behind on PRs for my open source Node.js project which has 40k download a month.

If I can find time, I will try, but its unlikely to any time soon. Sorry!

Glenn

[tantek]

Thanks @glennjones, appreciate the update. @mixedpuppy is this something you can help with? In particular can we at least answer (here in the issue) the questions that @glennjones raises in the initial issue description at the top?

[mixedpuppy]

What questions are being raised? Seems more a description of how the tests are put together for us.

[jgarber623]

Following up on @Zegnat's comment on #119…

Is this issue still valid? I did some quick looking and found this Bugzilla bug but I'm not familiar enough with the particulars to know the state of that bug.