AmpliPi icon indicating copy to clipboard operation
AmpliPi copied to clipboard

Update spotifyd

Open klay2000 opened this issue 1 year ago • 1 comments

What does this change intend to accomplish?

Checklist

  • [x] Have you tested your changes and ensured they work?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x] If applicable, have you updated the CHANGELOG?
  • [x] Does your submission pass linting & tests? You can test on localhost using ./scripts/test
  • [x] Have you written new tests for your core features/changes, as applicable?

Closes #721 !!!

For context here: the fix was A) Update spotifyd B) make the mpris metadata reader watch for an signal on another interface

klay2000 avatar Jun 27 '24 17:06 klay2000

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.94%. Comparing base (b516bb7) to head (dc5e7f7). Report is 155 commits behind head on main.

:exclamation: Current head dc5e7f7 differs from pull request most recent head 1fdb3e4

Please upload reports for the commit 1fdb3e4 to get more accurate results.

Files Patch % Lines
amplipi/mpris.py 50.00% 1 Missing :warning:
amplipi/streams.py 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
+ Coverage   50.90%   50.94%   +0.03%     
==========================================
  Files          25       26       +1     
  Lines        5838     6548     +710     
==========================================
+ Hits         2972     3336     +364     
- Misses       2866     3212     +346     
Flag Coverage Δ
unittests 50.94% <33.33%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 27 '24 17:06 codecov-commenter