AmpliPi icon indicating copy to clipboard operation
AmpliPi copied to clipboard

No streams

Open linknum23 opened this issue 3 years ago • 1 comments

Fixes #361

linknum23 avatar Aug 11 '22 15:08 linknum23

Codecov Report

Merging #363 (31ec11e) into develop (12cee39) will increase coverage by 0.40%. The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           develop     #363      +/-   ##
===========================================
+ Coverage    55.88%   56.29%   +0.40%     
===========================================
  Files           12       12              
  Lines         2811     2837      +26     
===========================================
+ Hits          1571     1597      +26     
  Misses        1240     1240              
Flag Coverage Δ
unittests 56.29% <83.33%> (+0.40%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
amplipi/models.py 95.00% <ø> (ø)
amplipi/ctrl.py 82.43% <83.33%> (+0.65%) :arrow_up:
amplipi/app.py 85.39% <0.00%> (+0.14%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 11 '22 15:08 codecov-commenter

Minor change to make sure that we can handle adding a stream when no other streams exist. The bugfix was a single line of code.

Main changes are to the test infrastructure to handle testing for this issue.

linknum23 avatar Aug 17 '22 18:08 linknum23

Alright fixed one more bug. I think this is good to go now!

linknum23 avatar Aug 17 '22 19:08 linknum23

Nevermind, looks like I unerthed another related bug

linknum23 avatar Aug 17 '22 20:08 linknum23

I'm not sure what the new bug is but I played around with no streams and it seems fixed!

Lohrer avatar Aug 17 '22 21:08 Lohrer

Dare I say this is actually fixed now?

linknum23 avatar Aug 18 '22 17:08 linknum23